Fix wasm-bindgen-test compatibility with doctests in Node.js #4535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses crashes when running wasm-bindgen-test in doctests, which execute in Node.js environments with specific limitations.
Problem:
When running doctests with wasm-bindgen-test, async code using spawn_local() would crash with "not a shared typed array" error. This occurred because:
Solution:
SharedArrayBuffer detection: Before using Atomics.waitAsync(), we now check if the memory buffer is actually a SharedArrayBuffer. If not, we gracefully fall back to the polyfill implementation.
Worker availability handling: In Node.js doctests, Worker may not be available or may behave differently. The polyfill now:
Design decisions:
This enables wasm-bindgen-test to work reliably in doctest environments while maintaining full functionality in production browser contexts.