set function shows an incorrect error message

[ruth-lim]

When there are no cards in the deck, and I try to set difficulty using set d/HARD, it says "Card index provided is invalid."

I think the error message does not match the error here since INDEX isn't an input parameter in the first place.

Perhaps, it would be more informative for the user if it said something along the lines of "There are no cards in deck to set difficulty to."

[soc-pe-bot]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Flawed error message provided using "solve"

Problem:
When no card is inside the list, it is suggested to have error message such as "No card is inside the list" instead of "The card index is invalid", as no index is provided in this case.

---

_{[original: nus-cs2103-AY2324S1/pe-interim#3275] [original labels: severity.Low type.FunctionalityBug]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the feedback, we concluded that this bug is rejected. This solve command works the same as solve 1, and since there is no cards present now, the index of the card exceeds the deck size, and hence it behaves as expected.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• I disagree

Reason for disagreement: [replace this with your explanation]

---

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: Right now, if the user inputs set d/Hard without specifying an index, the error message is "The card index provided is invalid." which is misleading. If no cards are present in the deck, the error message should clarify that there are no cards to apply the difficulty setting to, rather than implying an issue with a non-existent index that the user did not provide. A user trying to execute this command can be confused as to why there's an error with the index.

---