Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve migration experience #2186

Closed
markoaamunkajo opened this issue Nov 15, 2024 · 7 comments
Closed

Improve migration experience #2186

markoaamunkajo opened this issue Nov 15, 2024 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@markoaamunkajo
Copy link
Collaborator

Description:

User feedback, no screenshots. Looks like sign out did not happen properly for some reason for this user.

HI, migration of ruuvi app did not go smoothly when setting up new ipad from backup:

  • Sign in was left in weird state. App indicated I was signed in but it was showing blank where my email address should have been and no sensors were visible.
  • When I pressed “sign out” a warning was displayed and I did not do this, instead I deleted the app and reinstalled - no problem with this and everything is working now so this is just a suggestion for future improvement.

Migration issues are rare and low priority, keeping this in backlog for now. Solution for users at this point is to reinstall app.

@markoaamunkajo markoaamunkajo added the bug Something isn't working label Nov 15, 2024
@laurijamsa
Copy link
Member

How can we know that they are rare? I would approximate that every day averagely even more than ten of our iOS users switch to a new iOS device and if migration is still broken (we tried to fix it last year iirc), we should fix it again in near future.

@markoaamunkajo markoaamunkajo added this to the 2.13 milestone Nov 15, 2024
@priyonto
Copy link
Collaborator

Proper solution for this would be sign out user when they restore from backup.

@priyonto
Copy link
Collaborator

@laurijamsa @markoaamunkajo I have done testing by backing up device to iCloud and restore it twice, I did not face the issue reported by the user. I see I am signed in fine and getting the data from cloud as expected. However, I have done some improvements in the code which may or may not caused this and I am expecting it will work as expected. Additionally, as mentioned above we could sign out users automatically when they restore from backup, should we do it? Its not very intuitive but it will probably prevent bugs like reported ones. Do we want to do it?
My personal opinion is No, because I think its not intuitive, and if we can keep users signed in, we should try to continue to do that.

@laurijamsa
Copy link
Member

We can keep users signed in after restoring the app from backups to a new device IF it finally works now. So we need to be able to test it in real life before making the decision.

@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Nov 19, 2024
@markoaamunkajo
Copy link
Collaborator Author

Sad news, I cannot test this in a real way by migrating to second device due to this issue.
Image

@priyonto
Copy link
Collaborator

priyonto commented Dec 1, 2024

@markoaamunkajo You can probably download the app from firebase without REMOVING this app after restoring. That should give you same experience of downloading from AppStore.

@markoaamunkajo
Copy link
Collaborator Author

Finally tested this and when I open Ruuvi Station I am not signed in and no errors were shown. This is QA passed.

@markoaamunkajo markoaamunkajo removed their assignment Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants