Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with extended dataformat #459

Open
markoaamunkajo opened this issue Nov 26, 2024 · 4 comments
Open

Fix issues with extended dataformat #459

markoaamunkajo opened this issue Nov 26, 2024 · 4 comments
Assignees
@io53
Labels
ready to deploy

Comments

@markoaamunkajo
Copy link
Collaborator

Description:

Currently luminosity shows a value in UI, but in raw data it shows null.
This should be null/hidden in UI.

"luminosity": null,
@markoaamunkajo markoaamunkajo added the bug Something isn't working label Nov 26, 2024
@markoaamunkajo
Copy link
Collaborator Author

Also I don't see these in localisation, I updated the localisation otherwise.

Image

io53 pushed a commit that referenced this issue Nov 26, 2024
change translation key for pm sensors #459
af4d51b
@io53 io53 assigned markoaamunkajo and unassigned io53 Nov 26, 2024
@markoaamunkajo
Copy link
Collaborator Author

@io53 I don't have a lux sensor, but I see this value still even data reports "null".
It should be hidden from view when sensor is not present, am I correct?

@markoaamunkajo markoaamunkajo assigned io53 and unassigned markoaamunkajo Dec 2, 2024
io53 pushed a commit that referenced this issue Dec 3, 2024
added null data support for e0 #459
712b94b
@io53
Copy link
Collaborator

io53 commented Dec 3, 2024

Yes, but e0 didn't have invalid values support. It has it now.

@io53 io53 assigned markoaamunkajo and unassigned io53 Dec 3, 2024
@markoaamunkajo
Copy link
Collaborator Author

Works for me

@markoaamunkajo markoaamunkajo assigned io53 and unassigned markoaamunkajo Dec 5, 2024
@markoaamunkajo markoaamunkajo added ready to deploy and removed bug Something isn't working labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@io53 io53

Labels
ready to deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@io53 @markoaamunkajo