New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequence masking True/False mapping doc conformer #30

Closed

Atticus1806 opened this issue Jul 31, 2023 · 1 comment

Contributor

Atticus1806 commented Jul 31, 2023 •

edited

Loading

i6_models/i6_models/assemblies/conformer/conformer_v1.py

Line 55 in d2c8a24

    
                   :param sequence_mask: mask tensor where 0 defines positions within the sequence and 1 outside, shape: [B, T]

I just realized, this is wrong or did we agree on something else and I forgot? Since the MHSA module inverts the mask

Atticus1806 changed the title ~~Sequence masking True/False mapping~~ Sequence masking True/False mapping doc conformer

Atticus1806 mentioned this issue

add E-branchformer to i6_models #27

Merged

kuacakuaca mentioned this issue

fix param sequence_mask doc #46

Merged

Collaborator

kuacakuaca commented Mar 27, 2024

fixed by #46.

kuacakuaca closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment