Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coupled to git #23

Open
tj opened this issue Jul 9, 2012 · 3 comments
Open

coupled to git #23

tj opened this issue Jul 9, 2012 · 3 comments

Comments

@tj
Copy link

tj commented Jul 9, 2012

it would be great if this was not coupled to git, maybe just provide --run "make test" etc

@ryankee
Copy link
Owner

ryankee commented Jul 9, 2012

Hmmm, I can certainly see the benefit, but most of the app's use cases are directly tied to the idea of having a repo -- checking out clean code, building, etc.

A move to decouple git would be a pretty big shift in how the app operates, though it's a shift I've been contemplating. We'd likely want to move to the approach of storing a Concrete file in the project's directory with configuration options for SCM, build runners, pre-build runners, completion runners, etc. It'd certainly be a non-backwards compatible change and require new steps to setup a Concrete server. Would anyone be for/against this kind of approach?

As for the workaround flag, I'm not sure we'd be able to provide something like --run due to the reliance on git hooks and configuration variables. We'd have to set up a few other flags to handle completion runners, etc.

@tj
Copy link
Author

tj commented Jul 9, 2012

It's a great shift IMO, git has nothing to do with deploys at all

@deedubs
Copy link

deedubs commented Apr 24, 2013

I don't think having a file to config concrete would be a bad thing

concrete.json

{
  command: 'make test',
  success: 'make deploy',
  fail: 'make shame'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants