Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS vulnerability #17

Open
bottiger opened this issue Jun 27, 2011 · 1 comment
Open

XSS vulnerability #17

bottiger opened this issue Jun 27, 2011 · 1 comment

Comments

@bottiger
Copy link

The "site_url" in the comment field is vulnerable to XSS. Since I already have a fork of your project which has diverged a bit you wont get a pull request - sorry. But you can fix it by replacing line 33 in blog_kit/app/models/blog_comment.rb with:

return "<a href="".html_safe << self.site_url << "">".html_safe << name << "".html_safe
@bottiger
Copy link
Author

hmm - that didn't look too good - I'll try again:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bottiger