Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property tonalSubheading in function showColorPickerDialog not passed to underlying ColorPicker. #81

Closed
rydmike opened this issue Mar 16, 2024 · 1 comment
Closed

Property tonalSubheading in function showColorPickerDialog not passed to underlying ColorPicker. #81

rydmike opened this issue Mar 16, 2024 · 1 comment
Assignees
@rydmike
Labels
bug Something isn't working
Milestone
3.4.1

Comments

@rydmike
Copy link
Owner

rydmike commented Mar 16, 2024 •
edited
Loading

The property tonalSubheading in the convenience dialog function showColorPickerDialog is never passed along to the ColorPicker used to construct the dialog, causing the tonal sub heading to never show up in the resulting dialog.
@rydmike rydmike self-assigned this Mar 16, 2024
@rydmike rydmike added the bug Something isn't working label Mar 16, 2024
@rydmike rydmike moved this from To do to In progress in FlexColorPicker Mar 16, 2024
@rydmike rydmike added this to the 3.4.1 milestone Mar 16, 2024
@rydmike rydmike mentioned this issue Mar 16, 2024
Merged
@rydmike
Copy link
Owner Author

rydmike commented Mar 16, 2024

Fixed via: #80

@rydmike rydmike closed this as completed Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rydmike rydmike

Labels
bug Something isn't working
Projects
FlexColorPicker
Status: In progress
Milestone
3.4.1
Development

No branches or pull requests
1 participant
@rydmike