-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CupertinoTheme support #20
Comments
I was planning to look into practical side of it, I was just unsure if there is a need for it or interest in it. I don't actually think it would be difficult at all to add add support for it, so that The Still I guess there is no reason why I could not add support for in some form. For example something like I will look into and consider it for a future release. 😃 Thanks for the interest in this feature and for the suggestion 👍🏻 |
For info: A poll for this feature was added to discussions here #69 and it is also mentioned in docs here https://docs.flexcolorscheme.com/future_features. |
I'd like to suggest that it is not appropriate to leave it to consideration, vote or poll. Isn't the whole point Flutter exists is to be a cross platform solution? I was so happy to discover this library, for about 5 minutes until I found that Cupertino is not supported. Out of those 5 minutes I spent most of time in Playground demo very confused. Demo defaults to iPhone device and I couldn't understand why it doesn't show Cupertino controls, even somehow simulated. Still want to use it in project, hoping for Cupertino support in the future. |
What is expected concerning CupertinoThemeData?Glad to see some comments on this topic. 👍🏻 😄 I'm looking for and hoping for some input on what devs would like to see when it comes to Cupertino / iOS support in FlexColorScheme? If you use You can use Maybe
|
When it comes to making adaptive Material3 themes that looks different when using Material 3 in Android and on iOS, FCS and Playground already supports this. You can create a MaterialApp that gets M3 design on Android, but where those very opinionated Material 3 designs look different e.g. on iOS and macOS, like different (less) border radius and no elevation tint on iOS. These things can look quite alien on iOS, so you might prefer a more agnostic deign used at least on iOS. I still recommend sprinkling in at least platform aware dialogs on iOS as well. The New M3 switch looks very similar to iOS switches, so personally I think that is less critical, but certainly an option too still use the adaptive version. Now that M3 design also favors background colored AppBar by default, it is also less of an eye sore on iOS. FCS can remove the scroll under AppBar elevation and tint in iOS and still keep it in Android in M3 design. Look in the demo for pre-made designs and check out what the adaptive example does: https://twitter.com/RydMike/status/1642621071466672128 There will probably be more configurable platform adaptive properties in future FCS versions. Version 7 is the first one to have them and I am certainly looking for feedback on them: https://pub.dev/documentation/flex_color_scheme/latest/flex_color_scheme/FlexAdaptive-class.html |
I still have no real insights into what users expect from Cupertino support, since basically Cupertino has no real theming supporting in Flutter apart from a few colors. FlexColorScheme can make Material theme with different styles e.g. iOS while keeping another style on Android. So it now even have more support for iOs adaptive theming than any other Still grateful for any input and thoughts. I have added this for the Playground V10 milestone. |
Will you be looking at CupertinoTheme support as well in the future ?
The text was updated successfully, but these errors were encountered: