Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Instant Splash not triggered on short taps #239

Open
dickermoshe opened this issue Jul 7, 2024 · 4 comments
Open

[bug] Instant Splash not triggered on short taps #239

dickermoshe opened this issue Jul 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working V8 This issue concerns version 8 and will be addressed in it
Milestone

Comments

@dickermoshe
Copy link

Title says it all

Recording.2024-07-07.115600.mp4
@rydmike rydmike self-assigned this Jul 7, 2024
@rydmike rydmike added the bug Something isn't working label Jul 7, 2024
@rydmike rydmike added this to the 8.0.0 milestone Jul 7, 2024
rydmike added a commit that referenced this issue Jul 7, 2024
@rydmike
Copy link
Owner

rydmike commented Jul 7, 2024

Thanks, yes I agree it does not work well on very quick taps.

I added the same fix that I did for the adaptive_theme_demo repo, seemed to work well in it, so it should probably do so here too.

I won't land this fix until version 8.0.0 though, so keeping it open until then.

@rydmike rydmike added the V8 This issue concerns version 8 and will be addressed in it label Jul 7, 2024
@rydmike
Copy link
Owner

rydmike commented Oct 13, 2024

Thank you for your patience waiting for version 8.0.0.

FlexColorScheme package dev release 8.0.0-dev.1 has been published. This is a BIG update with breaking changes and many new features. It has its own dev pre-release of the Themes Playground as well, feel free to take a look. No new API changes are planned for the stable 8.0.0 release from this dev.1 release.

We would appreciate any feedback about found issues from early adopters.

This issue is solved in the new release, but I will not close this issue until the stable version of 8.0.0 has been released.

FOR INFO there will be no new features or changes in it compared to this one. Only any issues found from the quality assurance will be addressed. The stable release will also include many doc updates, but docs site will continue to be edited and revised AFTER the 8.0.0 stable release.

@dickermoshe
Copy link
Author

Super exciting!!!!

@rydmike There is a delay whenever values are changed on the new site.
Seems like some smoothing going on. (easy in)

Recording.2024-10-13.195516.mp4

@rydmike
Copy link
Owner

rydmike commented Oct 14, 2024

Yes this is expected.

When you change any Slider value, even just one step, or many, the theme animates from pervious value(s) to new value(s) for every value you slide via, what you are seeing is one or multiple theme transitions. This causes a delay in the result for the Duration of Flutter's built in Theme transition animation.

All component style updates in the Playground itself also use the theme you modify. If I would update the demo components directly to set new value, they would change instantly, but the purpose of Playground is to only do any change to any component shown and used in the app itself also and ONLY via the theme you change and make in the app. Every little change has theme transition animation from previous value to the new value. When operating and border radius with Slider, this looks like a delay, and it is since the theme is animating to each new new value you set/drag the Slider to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V8 This issue concerns version 8 and will be addressed in it
Projects
Status: To do
Development

No branches or pull requests

2 participants