timer issue on roborock gen1 id=ValueError

[Micha-Btz]

Hi,

Hi, I have a little bit trouble with my vacuum roborock gen1. Every Monday in the afternoon my vacuum goes to cleaning, but I don't have created a timer in valeduto for it. So I want to take a look at the cli. I don't think it is a bug in miiocli, I think something on the robot goes wrong.

miiocli roborockvacuum --ip 192.168.2.106 --token tzuiireertzu timer
Running command timer
[<Timer action=['start_clean', 100] cron=26 13 * * 1 enabled=True id=ValueError next_schedule=2022-05-09 13:26:00+02:00 ts=ValueError>, <Timer action=['start_clean', 60] cron=15 10 * * 1,4 enabled=True id=ValueError next_schedule=2022-05-09 10:15:00+02:00 ts=ValueError>]
Now I want to delete the timer, but I don't understand what the id is, which one is the right value?
miiocli roborockvacuum --ip 192.168.2.106 --token we45zrtu delete_timer ValueError
Usage: miiocli roborockvacuum delete_timer [OPTIONS] TIMER_ID
Try 'miiocli roborockvacuum delete_timer --help' for help.

Error: Invalid value for 'TIMER_ID': 'ValueError' is not a valid integer.

Since there is no valid id, I can't delete the timer. Can someone tell me a possibility to delete this timer anyway?
In which file on the robot the timer is written, maybe I can delete it there.

How can I get rid of the timer?

Thanks Micha

[rytilahti]

Could you try using --debug to see what the device is responding for the query? Could it be that the format has changed in newer firmware versions?

When that code was written, the vacuum responded with a string-encoded integer for the "id" which the library tries to convert to integer which could be the cause for the valueerror here. You can check https://github.com/rytilahti/python-miio/blob/master/miio/integrations/vacuum/roborock/vacuumcontainers.py#L423 for a complete example and compare it to the output you are receiving.

[Micha-Btz]

Thanks for the response. I don't know what's wrong, here the output with debug, I don't understand it.

miiocli --debug roborockvacuum --ip 192.168.2.106 --token zuiiozuti timer
INFO:miio.cli:Debug mode active
DEBUG:miio.integrations.vacuum.roborock.vacuum:Read stored sequence ids: {'seq': 2518, 'manual_seq': 0}
Running command timer
DEBUG:miio.click_common:Unknown model, trying autodetection. None None
DEBUG:miio.miioprotocol:Got a response: Container: 
    data = Container: 
        data = b'' (total 0)
        value = b'' (total 0)
        offset1 = 32
        offset2 = 32
        length = 0
    header = Container: 
        data = b"!1\x00 \x00\x00\x00\x00\x04\xea\xe2\xc6b}'\x8c" (total 16)
        value = Container: 
            length = 32
            unknown = 0
            device_id = unhexlify('04eae2c6')
            ts = 2022-05-12 15:28:12
        offset1 = 0
        offset2 = 16
        length = 16
    checksum = b'\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' (total 16)
DEBUG:miio.miioprotocol:Discovered 04eae2c6 with ts: 2022-05-12 15:28:12, token: b'ffffffffffffffffffffffffffffffff'
DEBUG:miio.miioprotocol:192.168.2.106:54321 >>: {'id': 2519, 'method': 'miIO.info', 'params': []}
DEBUG:miio.miioprotocol:192.168.2.106:54321 (ts: 2022-05-12 15:28:12, id: 2519) << {'partner_id': '', 'id': 2519, 'code': 0, 'message': 'ok', 'result': {'hw_ver': 'Linux', 'fw_ver': '3.5.8_004028', 'ap': {'ssid': 'Tuxoid_NG', 'bssid': '3C:37:12:4D:1C:FB', 'rssi': -64}, 'netif': {'localIp': '192.168.2.106', 'mask': '255.255.255.0', 'gw': '192.168.2.1\n127.0.0.1'}, 'model': 'rockrobo.vacuum.v1', 'mac': '78:11:DC:E7:AD:81', 'token': '52774565544c674c33416e5637316a72', 'life': 50535}}
DEBUG:miio.device:Detected model rockrobo.vacuum.v1
DEBUG:miio.miioprotocol:192.168.2.106:54321 >>: {'id': 2520, 'method': 'get_timer', 'params': ['']}
DEBUG:miio.miioprotocol:192.168.2.106:54321 (ts: 2022-05-12 15:28:12, id: 2520) << {'result': [['vor', 'on', ['26 13 * * 1', ['start_clean', 100]]], ['nach', 'on', ['15 10 * * 1,4', ['start_clean', 60]]]], 'id': 2520}
DEBUG:miio.miioprotocol:192.168.2.106:54321 >>: {'id': 2521, 'method': 'get_timezone', 'params': []}
DEBUG:miio.miioprotocol:192.168.2.106:54321 (ts: 2022-05-12 15:28:12, id: 2521) << {'result': ['Europe/Berlin'], 'id': 2521}
[<Timer action=['start_clean', 100] cron=26 13 * * 1 enabled=True id=ValueError next_schedule=2022-05-16 13:26:00+02:00 ts=ValueError>, <Timer action=['start_clean', 60] cron=15 10 * * 1,4 enabled=True id=ValueError next_schedule=2022-05-16 10:15:00+02:00 ts=ValueError>]
DEBUG:miio.integrations.vacuum.roborock.vacuum:Writing {'seq': 2521, 'manual_seq': 0} to ~/.cache/python-miio/python-mirobo.seq

File: ~/.cache/python-miio/python-mirobo.seq
       │ Size: 30 B
───────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ {"seq": 2521, "manual_seq": 0}

Maybe you see what's wrong.
Micha

[rytilahti]

Looks like that the timer id is an unexpected format so that's why it's failing. #1423 that should fix this issue.

[Micha-Btz]

Great, Can I help testing?

[Micha-Btz]

Hey,

I clone your repo, create a new branch, add the patch and install it via poetry.
I would say it worked. :-)

 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli  roborockvacuum --ip 192.168.2.106 --token wedfrghj timer
Running command timer
[<Timer action=['start_clean', 100] cron=26 13 * * 1 enabled=True id=vor next_schedule=2022-05-30 13:26:00+02:00 ts=None>, <Timer action=['start_clean', 60] cron=15 10 * * 1,4 enabled=True id=nach next_schedule=2022-05-26 10:15:00+02:00 ts=None>]
 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli roborockvacuum --ip 192.168.2.106 --token wedfrghj delete_timer vor
Running command delete_timer
['ok']
 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli  roborockvacuum --ip 192.168.2.106 --token wedfrghj timer
Running command timer
[<Timer action=['start_clean', 60] cron=15 10 * * 1,4 enabled=True id=nach next_schedule=2022-05-26 10:15:00+02:00 ts=None>]
 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli  roborockvacuum --ip 192.168.2.106 --token wedfrghj timer
Running command timer
[<Timer action=['start_clean', 60] cron=15 10 * * 1,4 enabled=True id=nach next_schedule=2022-05-26 10:15:00+02:00 ts=None>]
 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli  roborockvacuum --ip 192.168.2.106 --token wedfrghj timer
Running command timer
[<Timer action=['start_clean', 60] cron=15 10 * * 1,4 enabled=True id=nach next_schedule=2022-05-26 10:15:00+02:00 ts=None>]
 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli  roborockvacuum --ip 192.168.2.106 --token wedfrghj timer
Running command timer
[<Timer action=['start_clean', 60] cron=15 10 * * 1,4 enabled=True id=nach next_schedule=2022-05-26 10:15:00+02:00 ts=None>]

 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli roborockvacuum --ip 192.168.2.106 --token wedfrghj delete_timer nach
Running command delete_timer
['ok']
 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ poetry run miiocli  roborockvacuum --ip 192.168.2.106 --token wedfrghj timer
Running command timer
[]
 sysiphus in ~/source/python-miio on  schnuddel [?] ✦ ❯ miiocli  roborockvacuum --ip 192.168.2.106 --token wedfrghj timer
Running command timer
[]

Thanks
Micha

[rytilahti]

Thanks for testing, I'll merge it soon after the CI build is fixed! Feel free to mark the discussion as resolved. 👍