Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Schedule #1665

Closed
Aljutor opened this issue Jan 9, 2023 · 10 comments
Closed

Release Schedule #1665

Aljutor opened this issue Jan 9, 2023 · 10 comments

Comments

@Aljutor
Copy link

Aljutor commented Jan 9, 2023

Is your feature request related to a problem? Please describe.
It is possible to have some type of release schedule for minor updates like bug fixes and new simple devices?

Describe the solution you'd like
A once in month minor release would be nice to have.
But I don't trying to push you, and life sometimes hits hard, take your time.

Additional context
it's 5 months from last public release. And there was same type of a problem already #1463

@rytilahti
Copy link
Owner

The reason I didn't do a separate branching for the 0.5 series is that I expected the 0.6 could become shippable much faster. Alas, that did not happen...

On doing more regular releases, I suppose creating a separate branch & cherry-picking fixes from the master branch would not require that much effort. Do you have some specific candidates for PRs that should be released as part of the 0.5.13? If you (or someone else reading this) wish to help, adding a comment on the PRs that could go into the release would be really helpful: 0.5.12...master

The new release should contain only rather minor, non-breaking changes (i.e., fixes only) to keep it simple. Adding the supported model information could go in, but I'm not sure how useful they are–as long as the DeviceFactory changes are not included–for the time being as those will just suppress the warning logging.

@Aljutor
Copy link
Author

Aljutor commented Jan 11, 2023

I am interested in support for zhimi.airp.mb5a and leshow.humidifier.jsq1 but both requires #1581.
As on fixes side - I am not sure, but it better to ask other people about it.

Can #1581 be separated release? But it may require quite a lot of work to do, so I am not sure.

@rytilahti
Copy link
Owner

rytilahti commented Jan 11, 2023

Alas, that cannot be separated as most of the major changes are related to that. Especially if you are looking for homeassistant integration, which requires a major rewrite which is a work in progress. What's your use case? Perhaps it would be possible to create an alpha release if just having it installable via pypi for command-line (or other uses besides homeassistant) is what you need.

@kevin-kraus
Copy link

@rytilahti I've added an issue and PR in the HA/core repository (home-assistant/core#86104) asking for support for the Xiaomi Smart Air Purifier 4 Compact. I've seen that you have added support for this in November. (PR: #1581)

Would it be possible to add support for this into 0.5.13?

Best regards

Kevin

@rytilahti
Copy link
Owner

@kevin-kraus sorry, that's not possible. The genericmiot is one of those pieces that required changes throughout the library, and a rewrite of the homeassistant integration which I'm currently working on.

@kevin-kraus
Copy link

@kevin-kraus sorry, that's not possible. The genericmiot is one of those pieces that required changes throughout the library, and a rewrite of the homeassistant integration which I'm currently working on.

Thanks for your reply, any predictions how long it will take approximately until we can expect a new minor version and HomeAssistant integration? (e.g. 2 months etc.?)

@samuelspagl
Copy link

Hey @rytilahti, first of all thanks for this awesome library.
Have you any news for when there is a new release?

Thanks a lot in advance. :)

@Aljutor
Copy link
Author

Aljutor commented Mar 7, 2023

If there any small size tasks that can be contirbuted by someone else, I would like to help .

@kaystrobach
Copy link

Thank you for all the work.

is there a chance to cherry pick the air purifier 4 compact into the 0.5 branch? Would love it.

@rytilahti
Copy link
Owner

I just wrote about the current state of affairs in #1808 (comment) - let's close this issue and continue there. I'm hoping to get the last missing piece (#1814) done asap, but I'm going to need people to do some testing.

@Aljutor help on adding descriptors to existing integrations (#1617) would be very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants