Added support for dreame d10 plus #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
+ Coverage 80.79% 80.80% +0.01%
==========================================
Files 192 192
Lines 18545 18546 +1
Branches 4012 4012
==========================================
+ Hits 14983 14986 +3
+ Misses 3284 3282 -2
Partials 278 278
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rytilahti
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dreame D10 plus (https://home.miot-spec.com/spec/dreame.vacuum.r2205) seems to be using the same mapping as DREAME_TROUVER_FINDER. This allows for miio to use the robot properly by supporting it with dreamevacuum instead of genericmiot