Improve Yeelight by using common facilities #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes the common descriptor-based API for all device-inherited classes: - status() -> DeviceStatus: returns device status - descriptors() -> DescriptorCollection[Descriptor]: returns all defined descriptors - actions() -> DescriptorCollection[ActionDescriptor]: returns all defined actions - settings() -> DescriptorCollection[PropertyDescriptor]: returns all settable descriptors - sensors() -> DescriptorCollection[PropertyDescriptor]: returns all read-only descriptors - call_action(name, params): to call action using its name - change_setting(name, params): to change a setting using its name These functionalities are also provided as cli commands for all devices: - status - descriptors - actions - settings - sensors - call (call_action) - set (change_setting)
Add color and color temperature descriptors always and let downstreams handle filtering. Remove custom cli_format_yeelight in favor of common status reporting. Expose "toggle" and "set_default" as actions. Expose "color_mode" sensor.
rytilahti
force-pushed
the
yeelight/refactor/use_descriptorcollection_interfaces
branch
from
8e568d3 to
a6bc6c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
==========================================
+ Coverage 81.19% 81.35% +0.16%
==========================================
Files 193 193
Lines 18587 18555 -32
Branches 4022 4023 +1
==========================================
+ Hits 15091 15096 +5
+ Misses 3221 3184 -37
Partials 275 275
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rytilahti
deleted the
yeelight/refactor/use_descriptorcollection_interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add color and color temperature descriptors always and let downstreams handle filtering.
Remove custom cli_format_yeelight in favor of common status reporting.
Expose "toggle" and "set_default" as actions.
Expose "color_mode" sensor.
Old cli status output:
New:
Output for
actions: