Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add support for better pull request comment handling, with assignee, reviewer, etc. #154

Open
rytswd opened this issue Jun 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@rytswd
Copy link
Owner

rytswd commented Jun 27, 2021

Enhancement Area

Comvent Configuration YAML, Issue Comment Event Handling, Pull Request Comment Event Handling, Runtime

Details

Comment event can pull in a bit more information to control when Comvent is triggered for Pull Request specific use cases.

Use Cases

Assignee based trigger

When an assignee comments to their Issue or Pull Request, s/he can trigger some automation only when they want. This may be useful for automation where the assignee needs to trigger some preview build, etc.

Reviewer based trigger

Similar to the assignee, but when a review is requested, reviewers can trigger some other automation such as extra tests that are lengthy to run for each change.

Other possibilities

Code Owner based trigger

This would be a bit more tricky as finding code owner will require further delving into the associated PR and its affected files. I'd think assignee and reviewer would mostly cover these cases, so I'm not sure if there is a specific need for this.

@rytswd rytswd added the enhancement New feature or request label Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant