Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make powered by dynamic #74

Open
getlarge opened this issue Oct 5, 2021 · 2 comments
Open

feat: make powered by dynamic #74

getlarge opened this issue Oct 5, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@getlarge
Copy link
Contributor

getlarge commented Oct 5, 2021

Currently there is an hardcoded value ingenerate-pdf-template-helpers package and in each schemas repository template.hbs file.

@stiebitzhofer Should we make this value dynamic ?
We could start with extracting the base domain from the RefSchemaUrl and eventually make it customizable via a specific certificate input ?
@getlarge getlarge added the enhancement New feature or request label Oct 5, 2021
@stiebitzhofer
Copy link
Member

In my humble opinion, we should change the hardcoded value simply to s1seven.com. If somebody wants it desperately in the future we can consider dynamic values.

@stiebitzhofer
Copy link
Member

stiebitzhofer commented Sep 12, 2023 •
edited
Loading

Update: we probably should use digitalmaterialpassport.com or materialidentity.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stiebitzhofer @getlarge