Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE changes the file mode number #72

Open
BobBolch opened this issue Feb 4, 2022 · 5 comments
Open

EE changes the file mode number #72

BobBolch opened this issue Feb 4, 2022 · 5 comments
Labels
fixed in next release Staged in the next release candidate system

Comments

@BobBolch
Copy link
Collaborator

BobBolch commented Feb 4, 2022

If I edit an existing file. E.g.

EE TEST FILE A
Or
EE TEST FILE

The filemode is set to “A1” even if the existing file is “A2”.

@marXtevens
Copy link
Collaborator

marXtevens commented Feb 6, 2022

Verified the problem exists. Is the source code for EE on VM/370 CE?

EE TEST FILE A2 

File: TEST     FILE     A2  RECFM: V LRECL:  73(73) Lines:     1 Current:   TOP

      ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...
===== * * * Top of file * * *
===== /* This is a test file. */                                                
      * * * Bottom of file * * *

===> ffile
02=RingNext 03=Quit 06=SpltJ 07=PgUp 08=PgDw 10=PI 11=ClrCmd 12=Recall
Modified                                                  EE V1.2.5,  1 File(s)

I get this message.

Written new file: TEST FILE A2
Ready; T=0.07/0.10 17:36:34
l test file * ( date
Filename Filetype Fm  Format    Recs Blocks     Date    Time
TEST     FILE     A2  V    26      1      1  02/06/22   17:36
Ready; T=0.01/0.01 17:37:34

Then when I edit the file without specifying filemode, nor filemode number.

ee test file 

File: TEST     FILE     A1  RECFM: V LRECL:  73(73) Lines:     1 Current:   TOP

      ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...
===== * * * Top of file * * *
===== /* This is a test file. */                                                
      * * * Bottom of file * * *

Editing and modifying and saving does alter the filemode number.


File: TEST     FILE     A1  RECFM: V LRECL:  73(73) Lines:     2 Current:   TOP

      ....+....1....+....2....+....3....+....4....+....5....+....6....+....7...
===== * * * Top of file * * *
===== /* This is a test file. */                                               
===== /* Added a line to the file. */                                           
      * * * Bottom of file * * *


===> ffile
02=RingNext 03=Quit 06=SpltJ 07=PgUp 08=PgDw 10=PI 11=ClrCmd 12=Recall
Modified                                                  EE V1.2.5,  1 File(s)
File written: TEST FILE A1
Ready; T=0.08/0.17 17:43:33
l test file * ( date
Filename Filetype Fm  Format    Recs Blocks     Date    Time
TEST     FILE     A1  V    31      2      1  02/06/22   17:43
Ready; T=0.01/0.01 17:43:38

@BobBolch
Copy link
Collaborator Author

BobBolch commented Feb 7, 2022 via email

@SanLorenzo59
Copy link

I am massively reworking EE to bring more XEDIT features in. Actually i am researching how EE could integrate with bREXX.

I have a small fix for this problem here if you like to test it.

diff  eecore.c.e   eecore.c.a                                                       
900a901                                                                             
>   fm[1] = fInfo->filemode[1];  /* preserve file mode number of existing file */    

EE - preserve existing file mode number - 2022-10-15-1135b
EE - preserve existing file mode number - 2022-10-15-1135a
EE - preserve existing file mode number - 2022-10-15-1135c
EE - preserve existing file mode number - 2022-10-15-1135d
EE - preserve existing file mode number - 2022-10-15-1135e
EE - preserve existing file mode number - 2022-10-15-1135f

@BobBolch
Copy link
Collaborator Author

This fix is working for me.

@BobBolch BobBolch added the fixed in next release Staged in the next release candidate system label Oct 16, 2022
SanLorenzo59 pushed a commit to SanLorenzo59/mecaff that referenced this issue Oct 19, 2022
@SanLorenzo59
Copy link

Binaries available: https://github.com/SanLorenzo59/mecaff/releases/tag/v1.2.5a72

diff eecore.c.f eecore.c.a                                                       
30a31                                                                            
> #include <cmssys.h>                                                            
900a902                                                                          
>   fm[1] = fInfo->filemode[1];  /* preserve file mode number of existing file */ 
Ready(00001); T=0.19/0.24 05:19:51

diff eemain.h.f eemain.h.a  
24c24                                                                               
< #define VERSION "V1.2.5"                                                          
---                                                                                 
> #define VERSION "V1.2.5a72" /* https://github.com/s390guy/vm370/issues/72 fixed */   
Ready(00001); T=0.03/0.04 05:21:53                                                        

vmarc list EE125A72 VMARC A                                             
EEMAIN   H        A1. Bytes in=    4400, bytes out=       0 (     0%).  
EECORE   C        A1. Bytes in=   24160, bytes out=       0 (     0%).  
EECORE   TEXT     A1. Bytes in=   22800, bytes out=       0 (     0%).  
EEMAIN   TEXT     A1. Bytes in=   13440, bytes out=       0 (     0%).  
EE$D     MAP      A5. Bytes in=    5920, bytes out=       0 (     0%).  
EE$D     MODULE   A1. Bytes in=  162480, bytes out=       0 (     0%).  
EE$S     MAP      A5. Bytes in=    5920, bytes out=       0 (     0%).  
EE$S     MODULE   A1. Bytes in=  162400, bytes out=       0 (     0%).  
EE$VMARC EXEC     A1. Bytes in=     400, bytes out=       0 (     0%).  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next release Staged in the next release candidate system
Projects
None yet
Development

No branches or pull requests

3 participants