Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGO_PORT and render-db.properties port not working #89

Open
fcollman opened this issue Jul 6, 2018 · 1 comment
Open

MONGO_PORT and render-db.properties port not working #89

fcollman opened this issue Jul 6, 2018 · 1 comment
Assignees

Comments

@fcollman
Copy link
Contributor

fcollman commented Jul 6, 2018

The docker packaging and the configuration file advertise a port can be set, but that isn't actually getting read by the mongo configuration code, which makes it fall back to the default port.

We should likely remove the MONGO_PORT option from the docker packaging and the configuration file, or fix the code to allow it to work. It seems like its looking for host:port in the servers line of the file.

https://github.com/saalfeldlab/render/blame/d65fb27ce59b7100293c360ba902e6a9ec443ee6/render-ws/src/main/java/org/janelia/render/service/dao/DbConfig.java#L142

@trautmane
Copy link
Collaborator

I think removal makes sense. Actually, I'd like to remove all of the individual connection parameters and simply support the MONGO_CONNECTION_STRING since that should cover everything now and in the future. One downside is it complicates scripting (and maybe Ansible?) since the connection string can contain ampersands and other script unfriendly characters. Would you be opposed to removal of all the individual connection parameters? (note: we only use the connection string at Janelia)

@trautmane trautmane self-assigned this Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants