Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two misleading places, and one error. #48

Open
ghost opened this issue Feb 12, 2018 · 0 comments
Open

Two misleading places, and one error. #48

ghost opened this issue Feb 12, 2018 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 12, 2018

1/ hangperson_game_spec: There are several big blocks of pending, and within each of them have several small blocks of pending. Once The big blocks changed to not pending ( i.e. remove ;pending = true or change to pending = false), the small ones inside will got RED ERRORS even if it's still pending, and no matter you've rightly implemented those scripts or not. -- This is misleading, don't know if it's a bug of rspec's. IMHO it's worth mention in the instructions.

2/ Corner case, return :lose if (@guesses + @wrong_guesses).length > 6 , rspec should notice this kind of error, by add one or two correct letters in the 'should be lose after 7 incorrect guesses' test scenario.

3/ Minor ERROR: rerun -- cucumber features/ leads to endless cycle of reruns after first codes update, even if there's no codes update afterwards.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants