Suggestion to get rid of the "stopTime" storage property in the pro contract

[PaulRBerg]

The stopTime property redundant because the same information can be gleaned from the last segment milestone.

The only place where it is needed is the getWithdrawableAmount. It might be slightly more gas efficient to keep it as is in the getWithdrawableAmount, but this comes at a cost of 20,000 gas for committing this property in storage and, more importantly, at the cost of making it difficult to avoid the StackTooDeep issue.

Finally, I should clarify that this proposal is strictly about the stopTime storage property - the getStopTime getter is still helpful, and I am happy to keep it.

[andreivladbrg]

but this comes at a cost of 20,000 gas for committing this property in storage and

That's wrong, it would barely affect the gas. It would fit in a non complete storage slot

at the cost of making it difficult to avoid the StackTooDeep issue.

Was it difficult to avoid it in the create or in the getWithdrawableAmount function?

[PaulRBerg]

It would fit in a non complete storage slot

Good point!

Was it difficult to avoid it in the create or getWithdrawableAmount function?

In create. But I'm open to adding the stopTime back if it works now.

[andreivladbrg]

Haven't tested, but my gut is telling me that it should work.

[PaulRBerg]

Locking, we ended up bringing this property back (#240).