Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change contract address and expected token URI strings in tests #1071

Open
andreivladbrg opened this issue Oct 30, 2024 · 0 comments
Open

Change contract address and expected token URI strings in tests #1071

andreivladbrg opened this issue Oct 30, 2024 · 0 comments
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented Oct 30, 2024

The idea is to no longer skip these tests after we finish all changes related to 2.0.0:

address internal constant LOCKUP_DYNAMIC = 0xDB25A7b768311dE128BBDa7B8426c3f9C74f3240;
uint256 internal defaultStreamId;
/// @dev To make these tests noninvasive, they are run only when the contract address matches the hard coded value.
modifier skipOnMismatch() {

address internal constant LOCKUP_TRANCHED = 0xDB25A7b768311dE128BBDa7B8426c3f9C74f3240;
uint256 internal defaultStreamId;
/// @dev To make these tests noninvasive, they are run only when the contract address matches the hard coded value.
modifier skipOnMismatch() {
if (address(lockupTranched) == LOCKUP_TRANCHED) {

address internal constant LOCKUP_LINEAR = 0x3381cD18e2Fb4dB236BF0525938AB6E43Db0440f;
uint256 internal defaultStreamId;
/// @dev To make these tests noninvasive, they are run only when the contract address matches the hard coded value.
modifier skipOnMismatch() {

@andreivladbrg andreivladbrg added type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. priority: 3 Nice-to-have. Willing to ship without this. effort: medium Default level of effort. labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Development

No branches or pull requests

1 participant