Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Plugin: move Nodes section to the bottom, count them and order differently #1571

Open
rNoz opened this issue Oct 31, 2024 · 2 comments

Comments

@rNoz
Copy link

rNoz commented Oct 31, 2024

Would be possible to move the Nodes section to the bottom of the page, being the last section?

dav

To be able to operate with the collection, such as sharing it or checking the properties, we need to navigate to the bottom of the page, as all nodes will appear at the top.

The ideal solution would be to have some sort of pagination, to avoid loading and showing all the nodes in a single page. But this quick solution, at least, could facilitate navigating that page.

On the other side, maybe adding the number of nodes would be useful (e.g., Nodes (12)).
Also, even ordering by getlastmodified, not displayPath. Not sure what is displayPath here, as filenames (UUIDs + ics) are not in order:

image

Finally, a bug, I think the </section> shouldn't be outside the conditional (check the above "Nodes section" link).

What do you think? I can create the PR, but wanted to know first if it is acceptable.

@DeepDiver1975
Copy link
Member

I have no hard feelings about this - the browser plugin is for pure debugging purpose from my pov. Not really user facing and usability is of lesser importance in this case. Nevertheless: prs are always welcome. THX

@rNoz
Copy link
Author

rNoz commented Nov 30, 2024

Great! Thanks. I haven't touched php for a while, but I decided to do it this morning. PR already filled with tests and visual proofs, let's see what you think. Any suggestion or change, let me know ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants