diff --git a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java index 7f40ab94853..4cb3c678c07 100644 --- a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java +++ b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java @@ -319,6 +319,7 @@ public static boolean isReadOnly( case SnapshotPurge: case RecoverLease: case SetTimes: + case UnknownCommand: return false; default: LOG.error("CmdType {} is not categorized as readOnly or not.", cmdType); diff --git a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisRequest.java b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisRequest.java index ba24c113c7e..4e44a0567fb 100644 --- a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisRequest.java +++ b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisRequest.java @@ -103,7 +103,7 @@ public void testUnknownRequestHandling() throws IOException, // Create an instance of OMRequest with an unknown command type. OzoneManagerProtocolProtos.OMRequest omRequest = OzoneManagerProtocolProtos.OMRequest.newBuilder() - .setCmdType(OzoneManagerProtocolProtos.Type.TestUnknownCommand) + .setCmdType(OzoneManagerProtocolProtos.Type.UnknownCommand) .setClientId("test-client-id") .build(); diff --git a/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto b/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto index 8399d3ba855..a64283fb1c5 100644 --- a/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto +++ b/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto @@ -39,6 +39,7 @@ import "hdds.proto"; import "Security.proto"; enum Type { + UnknownCommand = 0; CreateVolume = 11; SetVolumeProperty = 12; CheckVolumeAccess = 13; @@ -138,7 +139,6 @@ enum Type { RefetchSecretKey = 121; ListSnapshotDiffJobs = 122; CancelSnapshotDiff = 123; - TestUnknownCommand = 124; } message OMRequest { diff --git a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java index fda8ebcd8a9..c04e8fdcdf2 100644 --- a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java +++ b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java @@ -200,11 +200,6 @@ public void testIsReadOnlyCapturesAllCmdTypeEnums() throws Exception { OzoneManagerProtocolProtos.Type.values(); for (OzoneManagerProtocolProtos.Type cmdtype : cmdTypes) { - if (cmdtype == OzoneManagerProtocolProtos.Type.TestUnknownCommand) { - // Skip OzoneManagerProtocolProtos.Type.TestUnknownCommand, since this - // cmdType is reserved for testing purposes only. - continue; - } OMRequest request = OMRequest.newBuilder() .setCmdType(cmdtype) .setClientId(clientId)