Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need support for hours into the next day #29

Open
HeathNaylor opened this issue Dec 7, 2022 · 1 comment
Open

Need support for hours into the next day #29

HeathNaylor opened this issue Dec 7, 2022 · 1 comment

Comments

@HeathNaylor
Copy link

Currently there is no support to say that a place, like a bar, is open until 2am. A simple solution for this would be to not bound the end time of the range to 23:59, instead allowing for things like 24:30, and for the 2am slot 26:00. We would prefer to do it this way so that we don't need to write logic in our application domain that looks for two contiguous time ranges (06:30 - 23:59 and 00:00 - 02:00) on the same day and combine those for display on the front end.

If this is something that would be merged in if we open a pull request then we would be willing to do the work required for this @sadekd.

@sadekd
Copy link
Owner

sadekd commented Dec 17, 2022

Try ->allowOverflowMidnight(true) 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants