From ac1f2377fc6fcd243750bcb91ba86dec5b796505 Mon Sep 17 00:00:00 2001 From: Sadiq Khoja Date: Mon, 9 Dec 2024 16:17:04 -0500 Subject: [PATCH] remove extra condition + rename test caption --- lib/model/query/datasets.js | 1 - test/integration/api/datasets.js | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/model/query/datasets.js b/lib/model/query/datasets.js index be50cbf9b..0bc1c79f7 100644 --- a/lib/model/query/datasets.js +++ b/lib/model/query/datasets.js @@ -288,7 +288,6 @@ const publishIfExists = (formDefId, publishedAt) => async ({ all, context, maybe JOIN datasets ds ON ds.id = dp."datasetId" JOIN ds_properties existing_properties ON existing_properties."datasetId" = ds.id AND LOWER(dp.name) = LOWER(existing_properties.name) - AND dp.name != existing_properties.name WHERE dpf."formDefId" = ${formDefId} AND existing_properties."publishedAt" IS NOT NULL AND dp."publishedAt" IS NULL diff --git a/test/integration/api/datasets.js b/test/integration/api/datasets.js index 838385fce..ccaadebf5 100644 --- a/test/integration/api/datasets.js +++ b/test/integration/api/datasets.js @@ -4064,7 +4064,7 @@ describe('datasets and entities', () => { })); - it('should reject when publishing duplicate property with different capitalization', testService(async (service, container) => { + it('should not reject for existing duplicate properties', testService(async (service, container) => { const alice = await service.login('alice'); await alice.post('/v1/projects/1/forms?publish=True')