Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnect V2 icon is broken #739

Open
jfschwarz opened this issue Jul 13, 2023 · 4 comments
Open

WalletConnect V2 icon is broken #739

jfschwarz opened this issue Jul 13, 2023 · 4 comments

Comments

@jfschwarz
Copy link

The Safe app sets the WalletConnect V2 metadata icon to a relative URL "/images/safe-logo-green.png" while it should be a full URL including host. This causes the connected wallet to display a broken icon:

image

This happens when connecting a wallet to the Safe app using the WalletConnect option.

@katspaugh katspaugh transferred this issue from safe-global/safe-wallet-web Jul 13, 2023
@katspaugh
Copy link
Member

Thanks Jan!

@dasanra @JagoFigueroa could you guys check?

@JagoFigueroa
Copy link
Contributor

JagoFigueroa commented Jul 13, 2023

Hi there! @jfschwarz could you share the dapp that you connected to via the WC safe app and it is using the icon from our app? I've tried with a few but I see that they usually use their own icon 😢

Cheers!

@jfschwarz
Copy link
Author

jfschwarz commented Jul 13, 2023

Hi @JagoFigueroa. Try with https://mech-omega.vercel.app/mechs/gno:0xb0dd814A7721b3fd2bA79f25dbA1f348383f8a31/679

(first connect any metamask account in the mech app, then there will be an input field for pasting the walletconnect key from Safe)

@JagoFigueroa
Copy link
Contributor

Thank you, I was able to reproduce it now 😄

No action from us needed here I would say señor @katspaugh as the connection is stablished from the web ui

wc.mp4

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants