Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WalletConnect] Enable connection without considering chain #763

Closed
dasanra opened this issue Sep 22, 2023 · 1 comment
Closed

[WalletConnect] Enable connection without considering chain #763

dasanra opened this issue Sep 22, 2023 · 1 comment

Comments

@dasanra
Copy link
Contributor

dasanra commented Sep 22, 2023

Overview

After few months, even now requiredChains is an optional parameter, many connection providers didn't adapt. This makes impossible to connect some dApps to the Safe when using WalletConnect. Also a drawback for these providers to prevent adding this compatibility is because many other Wallet apps require explicitly the property, making the migration complex.
wevm/wagmi#3027

Many providers accept a list of chains and always set the first one as required, even the others are set as optional. As the Safe can't guarantee that the required is always available the connection is automatically rejected.

Requirements

  • Accept the connection whenever we detect the chain where the current Safe exists is present on optionalChains
  • Accept the connection even the required chain is not the current Safe chain.
  • Reject the connection if the current chain is not present either on required or optional chains.
  • In case the Safe is already using the required chain just accept the connection and let the user operate normally.
  • In case the Safe is connected to a chain different from the required one, warn the user to check that they are using the correct chain on the dApp side

Designs

Links

@johannesmoormann
Copy link
Member

will be addressed with safe-global/safe-wallet-web#2535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants