Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate success dialogue in transaction builder #806

Open
jmealy opened this issue May 7, 2024 · 0 comments
Open

Inaccurate success dialogue in transaction builder #806

jmealy opened this issue May 7, 2024 · 0 comments
Labels
Bug 🐛 Something isn't working Minor

Comments

@jmealy
Copy link
Contributor

jmealy commented May 7, 2024

Bug description

When creating a single transaction from the transaction builder, and executing immediately, the success dialogue will tell you that your transaction batch is ready to execute, even though it has already been executed.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: sepolia

Steps to reproduce

  1. Go to the transaction builder, create a single transaction, and select create batch -> send batch.
  2. Execute the batch.
  3. Click Finish

Expected result

The success modal should only prompt you to sign/execute the batch if you have not already done so.

Obtained result

The success modal shown prompts you to execute the batch transaction, despite just having done so. [1]

Screenshots

[1]
image

@jmealy jmealy added the Minor label May 7, 2024
@katspaugh katspaugh transferred this issue from safe-global/safe-wallet-web May 7, 2024
@katspaugh katspaugh added the Bug 🐛 Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working Minor
Projects
Status: New issues
Development

No branches or pull requests

2 participants