Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tx: Fetch implementation abi when contract is proxy #818

Open
scottrepreneur opened this issue Aug 28, 2024 · 2 comments
Open

Custom tx: Fetch implementation abi when contract is proxy #818

scottrepreneur opened this issue Aug 28, 2024 · 2 comments

Comments

@scottrepreneur
Copy link

What is the feature about

When using the custom tx builder and attempting to interact with a proxied contract the Abi is fetched for the proxy contract.

Rather we should detect that the contract is a proxy and additionally fetch the abi for the proxy's implementation.

The list of requirements

  • detect that input contract is a proxy via interface
  • fetch implementation abi
  • Parse functions from the implementation abi

Designs/sketches

Should largely happen behind the scenes. Show a message that we've detected a proxy and fetched the implementation abi.

This would greatly enhance usability for proxy contracts via the custom transaction builder.

@katspaugh katspaugh transferred this issue from safe-global/safe-wallet-web Aug 28, 2024
@katspaugh
Copy link
Member

Isn’t that how it already works? If it detects a proxy, it offers to use the implementation ABI.

@scottrepreneur
Copy link
Author

It has not worked in my testing with the Base (Optimism) Portal contract. I've been needing to add the implementation ABI manually.
https://etherscan.io/address/0x49048044d57e1c92a77f79988d21fa8faf74e97e#writeProxyContract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants