Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposer button is enabled for nested safe signers #4743

Open
usame-algan opened this issue Jan 7, 2025 · 1 comment · May be fixed by #4744
Open

Add proposer button is enabled for nested safe signers #4743

usame-algan opened this issue Jan 7, 2025 · 1 comment · May be fixed by #4744
Assignees
Labels
bug Something isn't working

Comments

@usame-algan
Copy link
Member

Bug description

When connected with a wallet that is the owner of a nested safe the Add proposer button is enabled but it is not possible to add a proposer through a nested safe signature so the button needs to be disabled.

Steps to reproduce

  1. Open a Safe A that has another Safe B as owner
  2. Connect with a wallet that is an owner of Safe B
  3. Go to the settings page

Expected result

The Add proposer button is enabled

Obtained result

The Add proposer should be disabled

@usame-algan usame-algan added the bug Something isn't working label Jan 7, 2025
@usame-algan usame-algan moved this to In Progress in Safe{Wallet} Jan 7, 2025
@usame-algan usame-algan self-assigned this Jan 7, 2025
@usame-algan
Copy link
Member Author

Instead of adjusting the CheckWallet component I will create a new OnlyOwner component since we know that this button should only be available to owners and it reduces the scope and risk of breaking the behaviour a lot.

@usame-algan usame-algan linked a pull request Jan 7, 2025 that will close this issue
3 tasks
@usame-algan usame-algan moved this from In Progress to Peer Review in Safe{Wallet} Jan 7, 2025
@usame-algan usame-algan moved this from Peer Review to Ready for QA in Safe{Wallet} Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready for QA
Development

Successfully merging a pull request may close this issue.

1 participant