Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WalletConnect] Snapshot votes don't get registered, and need at times several submissions before being picked up #3522

Open
2 tasks
liliya-soroka opened this issue Apr 8, 2024 · 7 comments
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@liliya-soroka
Copy link
Member

"We've been using safe successfully to manage our DAO's operations for a while.
However recently there's been issues when using Safe with Snapshot. Votes don't get registered, and need at times several submissions before being picked up.
This wasn't an issue in the past, but is now impacting the smooth running of our operations.
What can be done to make sure our votes and proposals pass?

Steps:

  1. use n/m safe ( n>1)
  2. submits a vote/proposal as signer 1
  3. there is a delay (30min +) before the 2nd signer signes the vote/proposal
    Current result : the message gets submitted on-chain/off-chain but doesn't get recognised by snapshot

What to test:

  • off-chain message signing
  • on-chain message signing
@liliya-soroka
Copy link
Member Author

@francovenica , the card is converted to the issue, as you was able to reproduce in case of 30 mints delay

@liliya-soroka liliya-soroka added the bug Something isn't working label Apr 8, 2024
@liliya-soroka liliya-soroka changed the title Check snapshot vote signing in n/m safe ( snapshot app + WC) Votes don't get registered, and need at times several submissions before being picked up ( snapshot app + WC) Apr 12, 2024
@liliya-soroka liliya-soroka added the major Major bug (to be solved in the next release) label Apr 12, 2024
@katspaugh katspaugh changed the title Votes don't get registered, and need at times several submissions before being picked up ( snapshot app + WC) [WalletConnect] Snapshot votes don't get registered, and need at times several submissions before being picked up Apr 25, 2024
@katspaugh
Copy link
Member

Let's check if Snapshot votes have an intrinsic timeout.

@usame-algan
Copy link
Member

usame-algan commented Apr 25, 2024

I created a space in https://testnet.snapshot.org/ to test this but trying to connect to my Sepolia safe via WC doesn't work as its not supported.

Edit: There is a small bug in Snapshot that prevents this from working on Sepolia. I've opened a PR to address it in their codebase: snapshot-labs/snapshot#4692

@katspaugh
Copy link
Member

Update from Usame:

  • Usame will push a PR to their repo to fix their WC config

@usame-algan
Copy link
Member

The fix was merged. I will test this again

@usame-algan usame-algan self-assigned this Jun 24, 2024
@usame-algan
Copy link
Member

usame-algan commented Jun 24, 2024

Ok, I was able to test this on a testnet space that I created: https://testnet.snapshot.org/#/asd.eth

I checked both 1/1 and n/m safes with WC. Here are my results:

1/1

  • ✅ off-chain vote works
  • 🔴 on-chain vote doesn't work
    The screen is stuck and the vote is not getting picked up even after waiting (will update if it ever does)
    Image

n/m

  • ✅ off-chain vote works if the signing screen is kept open and all wallets sign in the same browser.
  • 🔴 off-chain vote doesn't work if the signing screen is closed e.g. if a second wallet wants to sign from a different browser/machine
  • 🔴 on-chain vote doesn't work in the same way as 1/1 on-chain

It might have to do with it being a testnet space but even their graphql endpoint doesn't return any votes.

@usame-algan
Copy link
Member

usame-algan commented Jun 25, 2024

After digging into it a bit more I realized that I should be using Snapshot as a safe app. Unfortunately the testnets.snapshot.org doesn't seem to have a relayer that is necessary to support safe votes so I created an issue on their board: snapshot-labs/snapshot#4793

Not necessarily a blocker but the only way to test is to have eligible tokens for an official space via snapshot.org and vote on a real proposal.

@usame-algan usame-algan removed their assignment Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Status: New issues
Development

No branches or pull requests

4 participants