Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Chain prefix toggle should reflect the address display #4261

Closed
TanyaEfremova opened this issue Sep 26, 2024 · 4 comments
Closed

UI: Chain prefix toggle should reflect the address display #4261

TanyaEfremova opened this issue Sep 26, 2024 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers minor Minor bug

Comments

@TanyaEfremova
Copy link
Contributor

Bug description

When clicked on Receive, as a user I can disbale chain prefix being pre-pended to the address. But when disabled, the prefix is still there in UI.

Environment

  • Browser: Chrome
  • Wallet: Any
  • Chain: Any

Steps to reproduce

  1. Go to any Safe account
  2. Click on QR icon to trigger Receive modal with the QR code
  3. See that the chain prefix is still there

Expected result

The chain prefix should disappear from the UI, when the toggle is off.

Obtained result

Screenshots

Screenshot 2024-09-26 at 16 30 55
@TanyaEfremova TanyaEfremova added bug Something isn't working good first issue Good for newcomers minor Minor bug labels Sep 26, 2024
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Sep 27, 2024
@compojoom compojoom removed this from Web Squad Sep 27, 2024
@Arya-A-Nair
Copy link
Contributor

Hey, can you assign me this. I would love to work on it

@usame-algan
Copy link
Member

@Arya-A-Nair yes sure, go for it!

@Arya-A-Nair Arya-A-Nair mentioned this issue Sep 29, 2024
Merged
3 tasks
@Arya-A-Nair
Copy link
Contributor

hey @usame-algan, I have raised a PR for the same over PR #4271

@usame-algan
Copy link
Member

Thanks @Arya-A-Nair!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers minor Minor bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@usame-algan @Arya-A-Nair @TanyaEfremova