Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable spending limit txs in new flow #2160

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jun 23, 2023

What it solves

Part of #2067

How this PR fixes it

  • Moves the existing spending limit flow into the new tx flow
  • Updates "Send again" for the new tx flow
  • Updates "Send" via address book for the new tx flow

How to test it

  1. Open a safe with a spending limit
  2. Create a new transaction
  3. Select the token with a spending limit
  4. Select Spending limit from the checkbox
  5. Press Next
  6. Observe the spending limit review screen
  7. Press Submit
  8. Observe a transaction without nonce
  9. Go to history
  10. Open a send transaction
  11. Press the three dots and select Send again
  12. Observe the new tx flow
  13. Go to address book
  14. Press send next to one of the entries
  15. Observe the new tx flow

Screenshots

Screenshot 2023-06-23 at 11 31 36

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

Branch preview

✅ Deploy successful!

https://spending_limit_tx--walletweb.review-wallet-web.5afe.dev

@usame-algan
Copy link
Member Author

For now I only copied the existing flow but I suggest we split them up in a separate PR and also style the inner components.

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit 83d0c35 into epic-tx-flow Jun 23, 2023
@usame-algan usame-algan deleted the spending-limit-tx branch June 23, 2023 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants