Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "Where's my wallet?" info #2171

Merged
merged 5 commits into from
Jun 28, 2023
Merged

fix: remove "Where's my wallet?" info #2171

merged 5 commits into from
Jun 28, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jun 26, 2023

What it solves

Resolves unclear warning.

How this PR fixes it

This removes the "Where's my wallet?" info box.

How to test it

Open the wallet connection modal and observe no "Why don't I see my wallet?" information in the modal.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh June 26, 2023 13:15
@iamacook iamacook self-assigned this Jun 26, 2023
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

Branch preview

✅ Deploy successful!

https://onboard_palette--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook changed the title fix: onboard warning colours fix: remove "Where's my wallet?" info Jun 26, 2023
@francovenica
Copy link
Contributor

The message is not present anymore.

Still, I wasn't able to trigger this "if not auto-selecting a wallet", to see if the message would popUp again. I tried connecting to ledger in one network and switch to another where is not present and refresh the page, but that doesn't seem to be the way to trigger the message.

@iamacook
Copy link
Member Author

iamacook commented Jun 27, 2023

Still, I wasn't able to trigger this "if not auto-selecting a wallet", to see if the message would popUp again.

The initial modal is not shown when we reconnect to a previously connected wallet.

Edit: it seems as though the element is still shown if the wallet connection is rejected. I'm going to look into this now. We've agreed that this is fine.

@usame-algan
Copy link
Member

Opened a PR against bnc-onboard repo to add an option to hide this notice

@iamacook iamacook merged commit a05c5b7 into dev Jun 28, 2023
7 checks passed
@iamacook iamacook deleted the onboard-palette branch June 28, 2023 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants