-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove "Where's my wallet?" info #2171
Conversation
Branch preview✅ Deploy successful! https://onboard_palette--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
The message is not present anymore. Still, I wasn't able to trigger this "if not auto-selecting a wallet", to see if the message would popUp again. I tried connecting to ledger in one network and switch to another where is not present and refresh the page, but that doesn't seem to be the way to trigger the message. |
The initial modal is not shown when we reconnect to a previously connected wallet. Edit: it seems as though the element is still shown if the wallet connection is rejected. |
Opened a PR against bnc-onboard repo to add an option to hide this notice |
What it solves
Resolves unclear warning.
How this PR fixes it
This removes the "Where's my wallet?" info box.
How to test it
Open the wallet connection modal and observe no "Why don't I see my wallet?" information in the modal.
Screenshots
Checklist