Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "Powered by" from balance changes #2181

Closed
wants to merge 1 commit into from

Conversation

iamacook
Copy link
Member

What it solves

Resolves duplicate "Powered by" labels.

How this PR fixes it

The "Powered by" label of the balance change section of the transaction flow has been removed.

How to test it

Create a transaction sending assets and observe the balance change without "Powered by".

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh June 27, 2023 08:00
@iamacook iamacook self-assigned this Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Branch preview

✅ Deploy successful!

https://remove_powered_by--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

The problem isn't the power by insignia but the fact that the accordion wrapper takes too much space. Suggest closing this for now.

@iamacook
Copy link
Member Author

The problem isn't the power by insignia but the fact that the accordion wrapper takes too much space. Suggest closing this for now.

It was my understanding that the duplicate"Powered by" was the issue and removing it was the proposed solution. cc @johannesmoormann

@katspaugh
Copy link
Member

katspaugh commented Jun 27, 2023

If instead of making the PR you had been listening, you would've heard we agreed that Lila will try to make it more compact.

@katspaugh katspaugh closed this Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
@katspaugh katspaugh deleted the remove-powered-by branch June 27, 2023 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants