Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: restore tracking of send modals #2185

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix: restore tracking of send modals #2185

merged 1 commit into from
Jun 27, 2023

Conversation

katspaugh
Copy link
Member

I've restored the tracking of the following tx modal events:

  • Send tokens
  • Send NFTs
  • Contract interaction

They are now tracked again when clicking on the corresponding buttons.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Branch preview

✅ Deploy successful!

https://tracking--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons look a bit off but I assume we will tackle this with the redesign

Screenshot 2023-06-27 at 13 13 41

@katspaugh
Copy link
Member Author

I'll merge this as an ugly reminder to design that modal :)

@katspaugh katspaugh merged commit 1da2c1c into epic-tx-flow Jun 27, 2023
6 of 7 checks passed
@katspaugh katspaugh deleted the tracking branch June 27, 2023 11:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants