Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(swaps): add usds stable coin #4205

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Feat(swaps): add usds stable coin #4205

merged 1 commit into from
Sep 20, 2024

Conversation

compojoom
Copy link
Collaborator

https://www.coingecko.com/en/coins/sky-dollar

What it solves

DAI has rebranded to SKY and that new token is most probably going to be used quite a lot in the future. We need to have the token address in the stablecoints array otherwise the swap widget will apply the wrong fee.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 19, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 953.95 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.23% 12010/15352
🔴 Branches 58.2% 3081/5294
🟡 Functions 65.3% 1891/2896
🟡 Lines 79.75% 10842/13595

Test suite run success

1485 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 0ccb104

@katspaugh katspaugh changed the title chore: add usds stable coing Feat: add usds stable coin Sep 19, 2024
@compojoom compojoom changed the title Feat: add usds stable coin Feat(swaps): add usds stable coin Sep 19, 2024
@compojoom compojoom merged commit b601216 into dev Sep 20, 2024
16 checks passed
@compojoom compojoom deleted the chore-stables branch September 20, 2024 09:46
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants