[Multichain] fix: Disable submit button while replaying safe [SW-173] #4211
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
979.49 KB (🟡 +25.24 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Forty-two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
507 B (🟢 -24.38 KB) |
979.98 KB |
/403 |
574 B (🟢 -3 B) |
980.05 KB |
/404 |
697 B (🟢 -1 B) |
980.17 KB |
/_error |
230 B (🟡 +2 B) |
979.71 KB |
/_offline |
1.09 KB (🟢 -3 B) |
980.58 KB |
/addOwner |
535 B (🟡 +1 B) |
980.01 KB |
/address-book |
26.11 KB (🟡 +16 B) |
1005.6 KB |
/apps |
50.17 KB (🟢 -11 B) |
1.01 MB |
/apps/bookmarked |
446 B (🟡 +1 B) |
979.92 KB |
/apps/custom |
41.79 KB (🟢 -17 B) |
1021.28 KB |
/apps/open |
54.74 KB (🟡 +2 B) |
1.01 MB |
/balances |
30.66 KB (🟢 -340 B) |
1010.14 KB |
/balances/nfts |
19.16 KB (🟢 -19 B) |
998.65 KB |
/cookie |
8.76 KB (🟡 +27 B) |
988.25 KB |
/home |
60.91 KB (🟡 +707 B) |
1.02 MB |
/imprint |
1.38 KB (🟡 +2 B) |
980.86 KB |
/licenses |
4.97 KB (🟢 -3 B) |
984.45 KB |
/new-safe/advanced-create |
36.38 KB (🟡 +1.24 KB) |
1015.87 KB |
/new-safe/create |
35.63 KB (🟡 +1.22 KB) |
1015.12 KB |
/new-safe/load |
16.38 KB (🟢 -32 B) |
995.87 KB |
/privacy |
15.9 KB (🟡 +24 B) |
995.38 KB |
/settings |
450 B (🟢 -1 B) |
979.93 KB |
/settings/appearance |
8.02 KB (🟢 -20 B) |
987.51 KB |
/settings/cookies |
7.64 KB (🟢 -26 B) |
987.12 KB |
/settings/data |
7.54 KB (🟢 -22 B) |
987.03 KB |
/settings/environment-variables |
9.13 KB (🟢 -25 B) |
988.61 KB |
/settings/modules |
9.76 KB (🟢 -21 B) |
989.25 KB |
/settings/notifications |
27.85 KB (🟡 +835 B) |
1007.33 KB |
/settings/safe-apps |
25.55 KB (🟢 -13 B) |
1005.04 KB |
/settings/security |
8.06 KB (🟢 -25 B) |
987.55 KB |
/settings/setup |
35.96 KB (🟢 -24 B) |
1015.44 KB |
/share/safe-app |
9.72 KB (🟢 -3 B) |
989.21 KB |
/stake |
589 B (🟢 -13 B) |
980.06 KB |
/swap |
723 B (🟢 -9 B) |
980.19 KB |
/terms |
11.24 KB (🔴 +10.71 KB) |
990.73 KB |
/transactions |
73.47 KB (🟢 -57 B) |
1.03 MB |
/transactions/history |
73.44 KB (🟢 -58 B) |
1.03 MB |
/transactions/messages |
39.12 KB (🟢 -46 B) |
1018.61 KB |
/transactions/msg |
29.5 KB (🟢 -18 B) |
1008.99 KB |
/transactions/queue |
31.22 KB (🟢 -46 B) |
1010.71 KB |
/transactions/tx |
21.05 KB (🟢 -18 B) |
1000.54 KB |
/welcome |
6.77 KB (🟢 -4 B) |
986.25 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1524 tests passing in 206 suites. Report generated by 🧪jest coverage report action from 3234a31 |
katspaugh
changed the title
| @@ -69,27 +69,33 @@ const ReplaySafeDialog = ({ | |||
| const customRpc = useAppSelector(selectRpc) | |||
| const dispatch = useAppDispatch() | |||
| const [creationError, setCreationError] = useState<Error>() | |||
| const [isSubmitDisabled, setIsSubmitDisabled] = useState<boolean>(false) | |||
There was a problem hiding this comment.
This is very similar to the submitDisabled variable.
Should we rename this to isSubmitting and inverse it?
|
|
||
| const selectedChain = chain ?? replayableChains?.find((config) => config.chainId === data.chainId) | ||
| if (!safeCreationData || !selectedChain) { | ||
| setIsSubmitDisabled(false) | ||
| return | ||
| } | ||
|
|
||
| // We need to create a readOnly provider of the deployed chain | ||
| const customRpcUrl = selectedChain ? customRpc?.[selectedChain.chainId] : undefined | ||
| const provider = createWeb3ReadOnly(selectedChain, customRpcUrl) | ||
| if (!provider) { | ||
| setIsSubmitDisabled(false) | ||
| return | ||
| } | ||
|
|
||
| // 1. Double check that the creation Data will lead to the correct address | ||
| const predictedAddress = await predictAddressBasedOnReplayData(safeCreationData, provider) | ||
| if (!sameAddress(safeAddress, predictedAddress)) { | ||
| setCreationError(new Error('The replayed Safe leads to an unexpected address')) | ||
| setIsSubmitDisabled(false) | ||
| return |
There was a problem hiding this comment.
Should we just use a try-catch-finally where we setIsSubmitDisabled(false) in the finally block?
ESLint Summary View Full Report
Report generated by eslint-plus-action |
1 similar comment
What it solves
Resolves SW-173
How this PR fixes it
isSubmitDisabledstateHow to test it
Checklist