Feat: cached safe overviews #4221
Conversation
src/store/safeOverviews.ts
Outdated
| nextBatch.forEach((item) => { | ||
| const overview = overviews.find( | ||
| (entry) => sameAddress(entry.address.value, item.safeAddress) && entry.chainId === item.chainId, | ||
| ) | ||
|
|
||
| item.callback({ data: overview }) | ||
| }) |
There was a problem hiding this comment.
since we're already calling the item.callback in the catch block, shouldn't this line be inside the try block?
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
990.09 KB (🟡 +35.56 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Twelve Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
511 B (🟢 -24.37 KB) |
990.59 KB |
/address-book |
26.09 KB (🟡 +5 B) |
1016.18 KB |
/apps/open |
54.74 KB (-1 B) |
1.02 MB |
/balances |
31 KB (🟡 +73 B) |
1021.09 KB |
/balances/nfts |
19.18 KB (-1 B) |
1009.27 KB |
/home |
60.96 KB (🟡 +744 B) |
1.03 MB |
/new-safe/advanced-create |
36.49 KB (🟡 +1.36 KB) |
1 MB |
/new-safe/create |
35.75 KB (🟡 +1.35 KB) |
1 MB |
/new-safe/load |
16.41 KB (🟡 +10 B) |
1006.5 KB |
/settings/notifications |
27.02 KB (-2 B) |
1017.11 KB |
/settings/setup |
35.98 KB (🟡 +5 B) |
1 MB |
/transactions/tx |
21.07 KB (-2 B) |
1011.16 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1548 tests passing in 206 suites. Report generated by 🧪jest coverage report action from a84a4e0 |
| () => multiChainGroupSafes.filter((safe) => undeployedSafes[safe.chainId]?.[safe.address] === undefined), | ||
| [multiChainGroupSafes, undeployedSafes], | ||
| ) | ||
| const { data: safeOverviews } = useGetMultipleSafeOverviewsQuery({ safes: deployedSafes, currency }) |
There was a problem hiding this comment.
Do we need to pass the walletAddress here as well?
There was a problem hiding this comment.
I do not pass it to have less dependencies and more likely cache hits.
This component is only interested in the signers and the threshold. The wallet address fetches the pending actions which is not needed here.
src/store/index.ts
Outdated
| @@ -53,6 +53,7 @@ const rootReducer = combineReducers({ | |||
| [ofacApi.reducerPath]: ofacApi.reducer, | |||
| [safePassApi.reducerPath]: safePassApi.reducer, | |||
| [slices.gatewayApi.reducerPath]: slices.gatewayApi.reducer, | |||
| [slices.safeOverviewApi.reducerPath]: slices.safeOverviewApi.reducer, | |||
There was a problem hiding this comment.
Wdyt about making this part of the gatewayApi slice to keep all related calls in one place? The SafeOverviewFetcher could be moved to its own file.
What it solves
Rewrites
useSafeOverviewshook using RTK query enabling:The goal is to have two hooks:
Both of them use a shared queue that waits for more requests to come in for 50ms or triggers a requests once 10 requests are in the queue.
Other changes
How to test it
While monitoring the outgoing network requests via e.g. developer tools in the browser:
Stats
On a full sidebar with multichain Safes this optimization with a fresh browser state reduces the safe overview requests from 38 to 18.
Checklist