Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Memory Leak #11

Open
sagalbot opened this issue Mar 23, 2020 · 0 comments
Open

Potential Memory Leak #11

sagalbot opened this issue Mar 23, 2020 · 0 comments

Comments

@sagalbot
Copy link
Owner

      if (val) {
        return document.addEventListener('click', this.clickAway);
      } else {
        return document.removeEventListener('click', this.clickAway);
      }

If Target exists within an element that has stopped event propagation somewhere along the chain, the removeEventListener here will never be called.

solution
Hook into a vue lifecycle hook (destroyed?) to ensure this event listener is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant