-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cocalc-jupyter ipywidgets: fully implement GridBoxModel and other layouts #5228
Comments
WORKAROUND: Use JupyterLab or Jupyter Classic in CoCalc. |
Better link to the code -- https://github.com/sagemathinc/cocalc/blob/master/src/smc-webapp/jupyter/output-messages/widget.tsx#L419 It's probably not hard to actually implement this properly... I should really do it soon. |
@jasongrout check out how I fixed this via 4dfb08a if you want to be really annoyed! 🤷 |
I'm reverting this, this breaks those controls. |
Ouch :). |
|
I disabled the ipywidgets thing again since it evidently subtly broke something -- no clue why. In any case, another approach is instead of moving the widgets up one level in the DOM (thus replacing their parents), I can copy the CSS and styles up one level, so that the parents enforce the right layout. Maybe that is enough. I don't know. My guess is that the current approach confuses cleanup the phosphor widgets and causes a crash. |
This is fixed by #7687 |
This is not surprising given the code in src/smc-webapp/jupyter/output-messages/widget.tsx which explicitly says this isn't fully implemented.
The text was updated successfully, but these errors were encountered: