Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little code formatting to make it easier for others to copy #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amrrs
Copy link

@amrrs amrrs commented Feb 28, 2022

No description provided.

@sahyagiri
Copy link
Owner

Thanks for the format suggestion.
I want a help in coding instead.
Can you write a helper function to download the model files into a central place like spacy/nltk does?

@amrrs
Copy link
Author

amrrs commented Mar 4, 2022

Do you mean this step python -m spacy download en_core_web_sm instead of asking the user to do, do you want that helper function to do?

@sahyagiri
Copy link
Owner

Currently the model files are in examples folder/"language"

Step 1. If you can write a utility function that downloads from that folder and keep it in a central place like python -m spacy download en_core_web_sm. In which case it would be python -m distinct-keywords download en. Or the alternate way is like NLTK or huggingface does. They detect the missing language files and download directly
2. Modify the constructor such that it will look at a predefined path (like spacy/nltk/huggingface) to see the already downloaded package. At present the function checks at current working directory.

I hope this is clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants