Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notification doesn't include package name and version [Bug] #300

Open
spodermenpls opened this issue Jun 24, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@spodermenpls
Copy link
Contributor

spodermenpls commented Jun 24, 2024

Sailfish OS VERSION: 4.6.0.13 and earlier

HARDWARE: Sony Xperia XA2

SailfishOS:Chum GUI application VERSION: 0.6.8-1 and earlier

BUG DESCRIPTION

According to the locale string %1 %2 updated, %1 is supposed to act as a placeholder for the package name and %2 as a placeholder for the package version, that get displayed in a notification popup after a successful package update. However, package name and version never get displayed on my end, and have never done so (at least to my recollection) in the past either, it only displays "updated", or in my German case "aktualisiert" (which was the original thing that made me pay attention, since if indeed intended as a single word, it should be spelled with a capital "A" in that scenario). The notifications after Install or Remove operations however do include package name and version, as intended.

STEPS TO REPRODUCE

If there's at least one update for a package available (unfortunately not that easy to re-create on demand..), execute it from the pulley menu and observe the notification pop-up banner after it is done.

ADDITIONAL INFORMATION

As mentioned in #167:

Affected strings in source TS file:
https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/translations/sailfishos-chum-gui.ts#L39-L56

Corresponding code:
https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/qml/sailfishos-chum-gui.qml#L13-L30

[Please consider which other pieces of information may be relevant: Denote if this is not always reproducible, if this is a regression (then name to which older version), attach relevant data such as log files or the systemd journal, provide screenshots etc.]

@spodermenpls spodermenpls added the bug Something isn't working label Jun 24, 2024
@Olf0
Copy link
Collaborator

Olf0 commented Jun 26, 2024

Thank you very much @spodermenpls for this excellent bug report. I will take a closer look at the corresponding code, when I find some time for SailfishOS-related things (but not the next couple of days, unfortunately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants