Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testcases to include more patch variants. #429

Open
nephros opened this issue Apr 15, 2023 · 2 comments
Open

Update testcases to include more patch variants. #429

nephros opened this issue Apr 15, 2023 · 2 comments
Labels
debt fallout and other issues originating from the past documentation documentation, Wiki and related patching related to activating, deactivating and handling Patches

Comments

@nephros
Copy link
Contributor

nephros commented Apr 15, 2023

Update the test cases with the information gathered in #426:

Either of the styles should work, with "lib" being either lib or lib64, and either resulting patch should apply on the other system (naturally).

Looking at my personal collection of installed patches, we have these styles of patch beginnings we should be able to deal with:

--- /usr/...
+++ /usr/...
--- a/usr/...
+++ b/usr/...
--- orig/usr/...
+++ patch/usr/...
--- jolla/usr/...
+++ developername/usr/...

And special case variants of the above for new files:

--- /dev/null
+++ {user,b,patch}/usr/...

Originally posted by @nephros in #426 (comment)

@nephros nephros added debt fallout and other issues originating from the past documentation documentation, Wiki and related patching related to activating, deactivating and handling Patches labels Apr 15, 2023
@nephros
Copy link
Contributor Author

nephros commented Apr 15, 2023

... also, actually test stuff using the test cases ;))

@nephros
Copy link
Contributor Author

nephros commented Apr 15, 2023

Actually the cases are already there (e.g. 32-to-64/ and 32-to-64-alt), but the evil thing about #426 is, the bug will not appear if the files to be patched have already been created previously by an unaffected patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt fallout and other issues originating from the past documentation documentation, Wiki and related patching related to activating, deactivating and handling Patches
Projects
None yet
Development

No branches or pull requests

1 participant