Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure instead of error #6

Open
jeff-cook opened this issue Sep 23, 2020 · 1 comment · May be fixed by #7
Open

Failure instead of error #6

jeff-cook opened this issue Sep 23, 2020 · 1 comment · May be fixed by #7

Comments

@jeff-cook
Copy link

In the JUnit schema they reserve error for an error in the testing process.

Indicates that the test errored.

The failure condition is for tests that run, but didn't pass the test.

Indicates that the test failed.

This distinction maters in the way the JUnit repot is viewed.
@jeff-cook
Copy link
Author

This may be as simple as updating https://github.com/salabs/pylint_junit/blob/master/src/pylint_junit/__init__.py#L47 to add_failure_info

@jeff-cook jeff-cook linked a pull request Sep 23, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use failure instead of error #6 jeff-cook/pylint_junit
1 participant
@jeff-cook