Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging into scikit-bot #3

Open
FirefoxMetzger opened this issue Sep 3, 2021 · 0 comments
Open

Merging into scikit-bot #3

FirefoxMetzger opened this issue Sep 3, 2021 · 0 comments

Comments

@FirefoxMetzger
Copy link

FirefoxMetzger commented Sep 3, 2021

👋 I'd like to add a FABRIC implementation to scikit-bot (repo-link) and - since the implementation here is already in python and looks pretty awesome 💯 - I was wondering if there is any interest in merging this repo into scikit-bot.

Here are some advantages I can see that would come with a merge:

  • easy extension to complex chains (both 2D and 3D) via skbot.transform (similar to ROS tf2 but numpy-based)
  • URDF and SDF support
  • a fully-fledged CI/CD pipeline that releases updates immediately (may become nightly in the future)
  • having python implementations of established robotics algorithms in one central place

The main disadvantage would be that the API/signature would change. It is, however, possible to - if desired - wrap scikit-bot and get the same API downstream. Another potential disadvantage would be a license change from MIT to Apache-2.0. Both are quite comparable though, so I doubt this will be a big problem.

If there is no interest I can, ofc, write my own implementation; I am mainly thinking that it would be more efficient to combine the two implementations and only maintain one.

Let me know what you think 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant