You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
Is your feature request related to a problem? Please describe
When configuring the ET_Client, loading the WSDL and refreshing the token, the current code only raise base Exceptions, which are not ideal to handle for developers
Potential HTTP errors coming from requests are not properly handled
In the ET_Client params, applicationType, if not None or blank, can be anything
I already created a PR to improve those 3 points: #123
Solutions
Create a base class for exceptions raised by the ET_Client, and subclasses for the different scenarios (configuration, loading WSDL, token refresh)
Use Response.raise_for_status to handle HTTP error responses coming from requests
Handle that case properly, and raise a new ConfigurationException in case of unallowed value
I also added tests for these error scenarios, in a specific file, FuelSDK/test_ET_Client_errors.py
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe
Exception
s, which are not ideal to handle for developersrequests
are not properly handledapplicationType
, if notNone
or blank, can be anythingI already created a PR to improve those 3 points: #123
Solutions
Response.raise_for_status
to handle HTTP error responses coming fromrequests
ConfigurationException
in case of unallowed valueI also added tests for these error scenarios, in a specific file,
FuelSDK/test_ET_Client_errors.py
The text was updated successfully, but these errors were encountered: