Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

Update Dependencies #101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

james-prodigy
Copy link

@james-prodigy james-prodigy commented Oct 30, 2019

Changes

Update the dependencies in the project.

How

Change Versions in gemfile
bundle upgrade

Issues

Fixes: #97

Signed-off-by: James Burgess <[email protected]>
@james-prodigy james-prodigy changed the title bump old deps to new versions Update Dependencies Oct 30, 2019
@chezsmithy
Copy link

+1 for getting this merged ASAP. We are blocked on using this SDK based on the dependencies.

@rcranley
Copy link

rcranley commented Nov 7, 2019

++1 For this. Anything we can do to help it merge? @sfdrogojan @epdejager

@rcranley
Copy link

rcranley commented Nov 8, 2019

@james-prodigy I would suggest bumping the version in lib/marketingcloudsdk/version.rb

@james-prodigy
Copy link
Author

Great thinking @rcranley
I'll push an update tomorrow morning.

Signed-off-by: James Burgess <[email protected]>
@james-prodigy
Copy link
Author

Anything else I can do?
@rcranley @sfdrogojan

@ghost
Copy link

ghost commented Nov 19, 2019

@james-prodigy, I think there is one more place where the version needs a bump.
In Gemfile.lock, in PATH / specs / sfmc-fuelsdk-ruby, I currently see a 1.3.0 there.

@chvreddy
Copy link

chvreddy commented Aug 5, 2020

@james-prodigy when can we expect this to merge to master, we have dependency on marketingcloudsdk gem and need this PR to get merged

@james-prodigy
Copy link
Author

@barberj Do you know when we can see this being merged in?

@guitarama
Copy link

There were some changes mentioned in #7 related to updates in savon (related to updates in gyoku). I opened an alternative to this PR that relaxes the requirement a bit (~> 2.3) and incorporates those changes: #112

@chvreddy
Copy link

chvreddy commented Oct 8, 2020

@barberj Waiting for this to get merged to master

@james-prodigy
Copy link
Author

@guitarama can I rebase this into your branch? that way we can incorporate the minor version bump

@barberj
Copy link
Contributor

barberj commented Oct 13, 2020

@james-prodigy I'm not apart of salesforce-marketingcloud org.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JSON library to version 2 to 3
7 participants