Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linting errors & Code styles #72

Open
Siddhant-K-code opened this issue Dec 29, 2023 · 0 comments
Open

Fix Linting errors & Code styles #72

Siddhant-K-code opened this issue Dec 29, 2023 · 0 comments

Comments

@Siddhant-K-code
Copy link
Contributor

Explicitly silenced these warnings for now. But, IMO, we should remove these lines and focus on fixing the lining errors. Wdyt?

Linting errors
/workspace/bazel-vscode-java/src/bazelLangaugeServerTerminal.ts
  7:8  error  ES2015 module syntax is preferred over namespaces  @typescript-eslint/no-namespace

/workspace/bazel-vscode-java/src/bazelRunStatus.ts
  4:8  error  ES2015 module syntax is preferred over namespaces  @typescript-eslint/no-namespace

/workspace/bazel-vscode-java/src/bazelTaskManager.ts
  7:8  error  ES2015 module syntax is preferred over namespaces  @typescript-eslint/no-namespace

/workspace/bazel-vscode-java/src/bazelTerminal.ts
  18:7   error  'initialDimensions' is defined but never used  @typescript-eslint/no-unused-vars
  34:28  error  'substring' is defined but never used          @typescript-eslint/no-unused-vars
  34:50  error  'args' is defined but never used               @typescript-eslint/no-unused-vars
  34:56  error  Unexpected any. Specify a different type       @typescript-eslint/no-explicit-any

/workspace/bazel-vscode-java/src/bazelprojectparser.ts
  29:10  error  'rawSections' is assigned a value but never used  @typescript-eslint/no-unused-vars

/workspace/bazel-vscode-java/src/commands.ts
   8:8   error  ES2015 module syntax is preferred over namespaces  @typescript-eslint/no-namespace
  50:11  error  Unexpected any. Specify a different type           @typescript-eslint/no-explicit-any
  60:11  error  Unexpected any. Specify a different type           @typescript-eslint/no-explicit-any

/workspace/bazel-vscode-java/src/extension.ts
  138:24  error  '_' is defined but never used             @typescript-eslint/no-unused-vars
  139:22  error  '_' is defined but never used             @typescript-eslint/no-unused-vars
  197:38  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  222:39  error  'doc' is defined but never used           @typescript-eslint/no-unused-vars

/workspace/bazel-vscode-java/src/jdtls.extension.api.ts
   62:14  error  Don't use `Object` as a type. The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`.
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead  @typescript-eslint/ban-types
  128:10  error  Unexpected any. Specify a different type                                                                                                                                                                                                                                                                                                                                                                        @typescript-eslint/no-explicit-any
  136:9   error  Unexpected any. Specify a different type                                                                                                                                                                                                                                                                                                                                                                        @typescript-eslint/no-explicit-any
  216:29  error  Unexpected any. Specify a different type                                                                                                                                                                                                                                                                                                                                                                        @typescript-eslint/no-explicit-any

/workspace/bazel-vscode-java/src/loggingTCPServer.ts
  7:7  error  'SERVER_START_RETRIES' is assigned a value but never used       @typescript-eslint/no-unused-vars
  8:7  error  'PORT_REGISTRATION_RETRIES' is assigned a value but never used  @typescript-eslint/no-unused-vars
  9:7  error  'RETRY_INTERVAL' is assigned a value but never used             @typescript-eslint/no-unused-vars

/workspace/bazel-vscode-java/src/provider/bazelRunTargetProvider.ts
  35:13  error  'args' is defined but never used          @typescript-eslint/no-unused-vars
  35:19  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  43:3   error  'element' is defined but never used       @typescript-eslint/no-unused-vars

/workspace/bazel-vscode-java/src/provider/bazelSyncStatusProvider.ts
  59:13  error  'element' is defined but never used  @typescript-eslint/no-unused-vars
  63:3   error  'item' is defined but never used     @typescript-eslint/no-unused-vars
  64:3   error  'element' is defined but never used  @typescript-eslint/no-unused-vars
  65:3   error  'token' is defined but never used    @typescript-eslint/no-unused-vars

/workspace/bazel-vscode-java/src/provider/bazelTaskProvider.ts
  35:45  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 30 problems (30 errors, 0 warnings)

Related #71 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant