Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trigger broken by #24 fix #33

Open
ashleybaldock opened this issue May 25, 2023 · 0 comments · Fixed by #32
Open

add trigger broken by #24 fix #33

ashleybaldock opened this issue May 25, 2023 · 0 comments · Fixed by #32
Labels
bug Something isn't working

Comments

@ashleybaldock
Copy link
Collaborator

PatternReplace(r'break', r'return false;', flags=re.MULTILINE),

ok so figured this out, it was confusing because I assumed that the issue with add trigger came in the past couple commits, but it was actually a subtle issue with the omega-mu fix (regex changes added PatternReplace(r'break', r'return false;', flags=re.MULTILINE), - and the add trigger code is the one place in that lua file that break is used not in an ipairs loop

quick fix pr #32

but also needs a regex fix :)

@ashleybaldock ashleybaldock added the bug Something isn't working label May 25, 2023
@ashleybaldock ashleybaldock linked a pull request May 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant